Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(complete): Env hook for dynamic completions #5671

Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat(complete): Env hook for dynamic completions #5671

merged 2 commits into from
Aug 12, 2024

Conversation

epage
Copy link
Member

@epage epage commented Aug 12, 2024 •
edited
Loading

Benefits over CompleteCommand

  • Faster, avoiding and extra Command creation and CLI parsing
  • More flexible
    • Easier to customize for more shells
    • Easier to customize for how to invoke (in this case env variable)
    • No risk for interfering with CLI parsing validation or derive logic

Fixes #3930

@epage epage force-pushed the env branch 2 times, most recently from 27c8c75 to 3d3497c Compare August 12, 2024 16:24
@epage epage enabled auto-merge August 12, 2024 16:25
@epage epage merged commit 6f88091 into clap-rs:master Aug 12, 2024
25 checks passed
@epage epage deleted the env branch August 12, 2024 16:54
This was referenced Aug 12, 2024
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch native completions to encourage env var initialization
1 participant
@epage