Query OUT_DIR at runtime. #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that Cargo no longer sets OUT_DIR when compiling build.rs, but it's still available at runtime. Therefore, switch `env!` to `env::var_os`.
|
I looked around briefly in Cargo's history to see where this change actually happened, but couldn't find it. We could use |
|
This is the correcter way of doing |
|
Great catch, I wasn't aware of this change! Thanks! @homu r+ |
|
📌 Commit c94a8f5 has been approved by |
homu
added a commit
that referenced
this pull request
Dec 7, 2016
Query OUT_DIR at runtime. It seems that Cargo no longer sets OUT_DIR when compiling build.rs, but it's still available at runtime. Therefore, switch `env!` to `env::var_os`.
homu
added a commit
that referenced
this pull request
Dec 7, 2016
Query OUT_DIR at runtime. It seems that Cargo no longer sets OUT_DIR when compiling build.rs, but it's still available at runtime. Therefore, switch `env!` to `env::var_os`.
|
☀️ Test successful - status |
|
👀 Test was successful, but fast-forwarding failed: 422 Required status check "coverage/coveralls" is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Cargo no longer sets OUT_DIR when compiling build.rs, but
it's still available at runtime. Therefore, switch
env!toenv::var_os.