Issue 771 #772
Merged
Issue 771 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ZSH completions use `[ and ]` for descriptions, but clap args use `[ and ]` for possible values and other auxillary arg information, this was creating a conflict. clap now escapes any square brackets before writing the help, i.e. `\\[ and \\]` which removes conflicts. Alternatives would be to switch `[ and ]` for `( and )` but this would create a slight difference in help messages and completions. Closes #771
|
@homu r+ |
|
📌 Commit 7144419 has been approved by |
homu
added a commit
that referenced
this pull request
Dec 9, 2016
homu
added a commit
that referenced
this pull request
Dec 9, 2016
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.