Add simple control mods for newrelic-infra service resource #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t want service managed by the module
|
@craigwatson since you were the last contributor to this repo. Any chance of this being reviewed? Happy to make amendments. |
|
HI @davehewy, thanks for the PR - it's definitely something I'm looking to review today, workload permitting 👍 |
|
+1 |
|
@craigwatson any updates? |
|
Thanks for the PR and apologies for the delay, version 2.3.0 has now been released to the Forge! 👍 |
|
@craigwatson great stuff. cheers 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this a useful (and missing) addition to the codebase. Thought i'd give contributing it back a stab. Please comment.