Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for terraform AWS provider issue #6715 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

userhas404d
Copy link

@userhas404d
Copy link
Author

Note: pinning to provider version 1.43.0 and lower will prevent this error without requiring changes to the existing module.

Our org has given the aws provider maintainers a heads up regarding this issue in the current aws provider so hopefully we see a fix implemented soon.

userhas404d added a commit to userhas404d/terraform-aws-ssm-patch-management that referenced this pull request Dec 17, 2018
@thrinadh238
Copy link

Hi

I need some information regarding this issue.

The above change is because of upgrading Terraform version or AWS made it mandatory???

@userhas404d
Copy link
Author

userhas404d commented Dec 18, 2018

@thrinadh238 a change was introduced in the terraform aws provider (v1.44.0 - see the 'heads up' link in my other comment for more details) that added the name and description options to the aws_ssm_maintenance_window_task resource. A welcome change, but one that does not allow them to be added conditionally (both are optional according to AWS). Pinning the terraform aws provider to versions less than 1.43 will avoid this issue unless they are explicitly defined in the resource definition as laid out in this PR.

TL;DR: This change is required because of a bug introduced in v1.44.0 of the terraform aws provider

@thrinadh238
Copy link

Hi,

Thanks for the quick reply.

Terraform documentation shows that it is optional. Please find the image below attached.

The version of AWS provider which you mentioned above is 1.43 but, we tried with below version
version = "~> 1.48.0".

It actually worked. It is not working with version 1.50

capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants