feat: Allow users set upgrade_settings.max_surge property #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Kubernetes Service changed the default max surge
in October release, so that for clusters based
on Kubernetes >1.28 max surge defaults to 10%, see
https://github.com/Azure/AKS/releases/tag/2023-10-01
Previously it was left blank which implied use of
value 1 under the bonnet.
Using the current version of Terraform AzureRM 3.86.0
leads to implicit resetting of the
max_surge
:The only workaround to avoid such confusing annoyance is to
set the
max_surge
with explicit value e.g. default "10%".But, this requires max_surge to be exposed to end-users of
this module. See also
hashicorp/terraform-provider-azurerm#24020
Closes #6