Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please assign the EU-GL step templates to study types and assure that they are configured correctly #99

Closed
DenoBeno opened this issue Aug 22, 2019 · 22 comments
Assignees
Labels
BB: Scenario Management Scenario Management Building Block

Comments

@DenoBeno
Copy link

DenoBeno commented Aug 22, 2019

related to #39

@p-a-s-c-a-l : I need you to double check all the "default" templates and assure they are correctly assigned to the studies. Tell me if you need more templates.

FYI:

All the currently defined templates can be easily found now here

I have defined two sets of templates:

  1. "default" ones are exactly as they were in our studies so far. Except that the MCDA information is only set in the Assess Risks and Impact step . That's this one: https://csis.myclimateservice.eu/node/938/edit/template . Since I have no idea which applications are working now, it's best if you go through them and assure that all is correct.

  2. "simple" ones are rather empty at the moment - just maps and twins. I will rename them to "testing" because that's what they are used for now - testing how new features work without breaking the studies that use the "standard" template type.

  3. Assigning the templates to study types can be done quite easily, just edit the corresponding taxonomy term. https://csis.myclimateservice.eu/admin/structure/taxonomy/manage/study_type/overview

@p-a-s-c-a-l
Copy link
Member

ATM the MCDA App is broken, probably due to undocumented format changes in the EMIKAT API. Therefore I'm going to remove it from all Assess Risks and Impact step templates until the problem has been fixed.

Transformation of Map Component to iFrame is in progress, once completed, this will require to change all step temples that use a map component. I'm going to test the new iFrame based Map Component in the "testing" templates first, the "default" templates will continue to use the ReactMount Map Component for now.

@p-a-s-c-a-l p-a-s-c-a-l added the BB: Scenario Management Scenario Management Building Block label Aug 23, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.4 CLARITY CSIS v2 milestone Aug 23, 2019
@p-a-s-c-a-l
Copy link
Member

Or maybe it's better to hide the the Scenario Analysis Tab completely and re-enable when the APIs have stabilised.

@patrickkaleta What would be the best option to hide Assess Risks and Impact/Scenario Analysis? Maybe set Page settings/permissions to role:administrator ?

@DenoBeno
Copy link
Author

There is a more general ticket asking for a way to hide sub-steps. I didn't look at the way they are implemented, but I suspect that they might disappear if there is nothing to show or if the system cannot show anything.

@patrickkaleta
Copy link
Contributor

Or maybe it's better to hide the the Scenario Analysis Tab completely and re-enable when the APIs have stabilised.

@patrickkaleta What would be the best option to hide Assess Risks and Impact/Scenario Analysis? Maybe set Page settings/permissions to role:administrator ?

That's the issue Denis is talking about. I'm working on that now and during that process I will hide the Scenario Analysis tab.

@p-a-s-c-a-l
Copy link
Member

If I want to replace map components (Extended iFrame) in e.g. all Characterize Hazard steps, how can this be done?

@p-a-s-c-a-l
Copy link
Member

@p-a-s-c-a-l : I need you to double check all the "default" templates and assure they are correctly assigned to the studies. Tell me if you need more templates.

We should remove the following steps from all study templates, since we there's ATM nothing to show there:

@DenoBeno
Copy link
Author

DenoBeno commented Sep 4, 2019 via email

@p-a-s-c-a-l
Copy link
Member

bulk edit.

is bulk edit installed? where do it find it?

@DenoBeno
Copy link
Author

DenoBeno commented Sep 5, 2019

@p-a-s-c-a-l : I need you to double check all the "default" templates and assure they are correctly assigned to the studies. Tell me if you need more templates.

We should remove the following steps from all study templates, since we there's ATM nothing to show there:

* Analyze vulnerability step See [clarity-h2020/csis#16 (comment)](https://github.com/clarity-h2020/csis/issues/16#issuecomment-507636499)

* Appraise Adaptation Options

* Implement/Integrate Adaptation Action Plan

OK, I'm removing these steps from all templates.

@DenoBeno DenoBeno closed this as completed Sep 5, 2019
@DenoBeno
Copy link
Author

DenoBeno commented Sep 5, 2019

@p-a-s-c-a-l : I need you to double check all the "default" templates and assure they are correctly assigned to the studies. Tell me if you need more templates.

We should remove the following steps from all study templates, since we there's ATM nothing to show there:

* Analyze vulnerability step See [clarity-h2020/csis#16 (comment)](https://github.com/clarity-h2020/csis/issues/16#issuecomment-507636499)

* Appraise Adaptation Options

* Implement/Integrate Adaptation Action Plan

I'm a bit confused by https://csis.myclimateservice.eu/taxonomy/term/2221

Expert studies can in principle have any steps they want to add to the data package. Except the "local effects", makes no sense to have that in the expert mode.

@p-a-s-c-a-l
Copy link
Member

I'm a bit confused by https://csis.myclimateservice.eu/taxonomy/term/2221

Yes, some steps are missing here.

@p-a-s-c-a-l
Copy link
Member

is bulk edit installed? where do it find it?

@p-a-s-c-a-l p-a-s-c-a-l reopened this Sep 5, 2019
@DenoBeno
Copy link
Author

DenoBeno commented Sep 5, 2019

If I want to replace map components (Extended iFrame) in e.g. all Characterize Hazard steps, how can this be done?

This way.

  1. Be careful. With great power...
  2. Go here: https://csis.myclimateservice.eu/maintenance/gl-steps
  3. Carefully filter the nodes you need. E.g. I'm doing this with the test template only now.

grafik

  1. choose the ones you really want to edit ("2" on illustration above), then click on "Modify field values"
  2. chose the variable you want to set, then choose the value.
    grafik
  3. Click "Apply"

@DenoBeno
Copy link
Author

DenoBeno commented Sep 6, 2019

I have added a second bulk-edit form for the study types. This one is allowed for administrators and editors.

grafik

This is good for assigning or adding steps to several studies at a time and also provides a good overview.

grafik

If "add multi values" is enabled, the entry will only be added to existign ones. Otherwise teh old ones will be overwritten.

I'm done with this, feel free to ask if you need anything else.

@therter
Copy link
Contributor

therter commented Sep 16, 2019

The option "Select / deselect all results in this view" (see the red rectangle in the screenshot ) is very dangerous, because this option ignores the applied filter. If the user use this option, all workflow steps will be selected and not only the steps, which fulfil the current filter criteria.
Especially when the user has more than one page with matches, he will mostly assume that only the matches are selected.

BulkEdit

@patrickkaleta
Copy link
Contributor

Nice catch @therter. That checkbox is should be either fixed or removed. I'll look into it

@DenoBeno
Copy link
Author

This is IMO a bug in the module. I'll report it.

@therter
Copy link
Contributor

therter commented Sep 20, 2019

Additional info:
Until this bug is fixed, it is of course possible to use the check boxes next to the titles to mark a single step, or the checkbox in the table header to select all steps of the current page. The number of selected steps is shown under the apply button and should be used to ensure that not accidentally too many steps are selected.

@DenoBeno
Copy link
Author

Can we close this now?

@p-a-s-c-a-l
Copy link
Member

no, we have to add the new table components when they are finished.

@p-a-s-c-a-l
Copy link
Member

OK, Study types are now configured. Main difference between basic screening, advanced screening and expert is that only in advanced screening (with EMIKAT calculation) we show table components (because they depend on EMIKAT API).

grafik

@DenoBeno
Copy link
Author

DenoBeno commented Oct 2, 2019

Additional info:
Until this bug is fixed, it is of course possible to use the check boxes next to the titles to mark a single step, or the checkbox in the table header to select all steps of the current page. The number of selected steps is shown under the apply button and should be used to ensure that not accidentally too many steps are selected.

just FYI, I have removed paging now. For now it's OK, in the future this might cause the view to load extremely long. But by then maybe the bug will be fixed upstreams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Scenario Management Scenario Management Building Block
Projects
None yet
Development

No branches or pull requests

4 participants