Min Initial Deposit (Recreated using main as base branch)

[fragwuerdig]

Summary of changes

See #74 and #41.

Report of required housekeeping

• Github issue OR spec proposal link
• Wrote tests
• Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
• Added a relevant changelog entry: clog add [section] [stanza] [message]

---

(FOR ADMIN) Before merging

• Added appropriate labels to PR
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
• Confirm added tests are consistent with the intended behavior of changes
• Ensure all tests pass

[fragwuerdig]

@nghuyenthevinh2000: I recreated this PR (now based non main). Can you test the upgrade handler/migration for this? I fear the automated upgrade test is really doing nothing... I would appreciate you manual test that you have been doing for #74.

[ZaradarBH]

LGTM m8. Only have a few minor cosmetic suggestions :)

[nghuyenthevinh2000]

Base logic looks fine

1. a test should be needed
2. func (AppModule) ConsensusVersion() uint64 { return 2 } in x/treasury/module.go should return 3
3. you need to add an upgrade handler in app/upgrades as well since this is state migration in x/treasury. It is also prerequisite to run upgrade-test ci

[fragwuerdig]

i wrecked this branch argh - that's because I do things in a hurry........

[ZaradarBH]

i wrecked this branch argh - that's because I do things in a hurry........

[fragwuerdig]

Ok. I saved the branch 🤣. Wrote another test for this (half-automated spinning single validator node doing the min initial deposit prop via CLI). Where do I put this script?

@nghuyenthevinh2000 : I also comply with your change requests. Can you resolve them?

[ZaradarBH]

Ok. I saved the branch 🤣. Wrote another test for this (half-automated spinning single validator node doing the min initial deposit prop via CLI). Where do I put this script?

@nghuyenthevinh2000 : I also comply with your change requests. Can you resolve them?

Normally ad-hoc scripts would go into the "contrib" folder, but I recon we can drop it in the new "tests" folder we are setting up for the automated testing stuff :)

[nghuyenthevinh2000]

LGTM