Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add testing framework document #142

Merged
merged 1 commit into from
Feb 24, 2023
Merged

docs: add testing framework document #142

merged 1 commit into from
Feb 24, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

Summary of changes

Closes: #69

I add this pr so that we can comment directly to where changes are needed

cc: @ZaradarBH @inon-man @fragwuerdig @edk208

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@nghuyenthevinh2000 nghuyenthevinh2000 marked this pull request as draft February 22, 2023 06:24
@nghuyenthevinh2000 nghuyenthevinh2000 changed the title add testing framework add testing framework document Feb 22, 2023
@nghuyenthevinh2000 nghuyenthevinh2000 changed the title add testing framework document docs: add testing framework document Feb 22, 2023
@inon-man
Copy link
Collaborator

This is great. We have to learn from mistake. If we had time, measures should be taken, and prevent similar problems from recurring.

@ZaradarBH ZaradarBH added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Feb 22, 2023
@ZaradarBH ZaradarBH added this to the Proposal 11168 milestone Feb 22, 2023
@ZaradarBH ZaradarBH added the enhancement New feature or request label Feb 22, 2023
@ZaradarBH ZaradarBH self-requested a review February 22, 2023 16:27
@ZaradarBH ZaradarBH marked this pull request as ready for review February 24, 2023 14:31
@ZaradarBH ZaradarBH merged commit b5967cb into main Feb 24, 2023
@nghuyenthevinh2000
Copy link
Contributor Author

let's get this rolling

@fragwuerdig fragwuerdig deleted the testing-refactor branch May 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Establish automated testing frameworks of new GH pulls
5 participants