Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test framework implementation plan #167

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Test framework implementation plan #167

merged 2 commits into from
Mar 7, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

Summary of changes

Closes: #69

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

ZaradarBH
ZaradarBH approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@nghuyenthevinh2000 nghuyenthevinh2000 merged commit 3dda133 into main Mar 7, 2023
@fragwuerdig fragwuerdig deleted the test-framework-implementation-plan branch May 25, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZaradarBH ZaradarBH ZaradarBH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Establish automated testing frameworks of new GH pulls
2 participants
@nghuyenthevinh2000 @ZaradarBH