-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terra operator docker refactor #172
Conversation
@ZaradarBH you will want to check this out, this one touches a lot your old work on docker. I remove cors custom configuration (default instead) since even validator node doesn't need it. It is only needed when serving web client. I am currently using docker repository nghuyenthevinh2000 until we have classic-terra docker repository. Once we have it, I will mark this pr as ready I have tried this on both classic-terra/core and terra-operator. Node is producing block. |
Cant you just install it from https://github.com/CosmWasm/wasmvm/releases/tag/v1.2.1? ;) We ended up using Ubuntu since we had issues getting "OpenRC" to work on the alpine image @ https://wiki.alpinelinux.org/wiki/OpenRC. Granted our relative inexperience with terrad at the time, Woelig and I decided that the easy workaround for this was to just using Ubuntu and install libwasm via apt or manually depending on our options. :) |
the usual Dockerfile for terrad binary can work with terraclassic.terrad-node image so I think it is more clean to keep one usuable Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM m8. A few suggestions, nothing critical :)
Summary of changes
Report of required housekeeping
(FOR ADMIN) Before merging