Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terra operator docker refactor #172

Merged
merged 11 commits into from
Mar 18, 2023
Merged

Terra operator docker refactor #172

merged 11 commits into from
Mar 18, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

@nghuyenthevinh2000 nghuyenthevinh2000 commented Mar 10, 2023

Summary of changes

  1. Move docker folder to contrib folder and rename to terra-operator
  2. Remove Dockerfile.terraclassic.terrad-binary since it lacks wasm lib. Use original classic-terra binary Dockerfile instead
  3. Add a section to start a testnode

Screenshot 2023-03-10 at 17 31 16

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@nghuyenthevinh2000
Copy link
Contributor Author

@ZaradarBH you will want to check this out, this one touches a lot your old work on docker.

I remove cors custom configuration (default instead) since even validator node doesn't need it. It is only needed when serving web client.

I am currently using docker repository nghuyenthevinh2000 until we have classic-terra docker repository. Once we have it, I will mark this pr as ready

I have tried this on both classic-terra/core and terra-operator. Node is producing block.

@ZaradarBH
Copy link
Contributor

Cant you just install it from https://github.com/CosmWasm/wasmvm/releases/tag/v1.2.1? ;) We ended up using Ubuntu since we had issues getting "OpenRC" to work on the alpine image @ https://wiki.alpinelinux.org/wiki/OpenRC. Granted our relative inexperience with terrad at the time, Woelig and I decided that the easy workaround for this was to just using Ubuntu and install libwasm via apt or manually depending on our options. :)

@nghuyenthevinh2000
Copy link
Contributor Author

Cant you just install it from https://github.com/CosmWasm/wasmvm/releases/tag/v1.2.1? ;) We ended up using Ubuntu since we had issues getting "OpenRC" to work on the alpine image @ https://wiki.alpinelinux.org/wiki/OpenRC. Granted our relative inexperience with terrad at the time, Woelig and I decided that the easy workaround for this was to just using Ubuntu and install libwasm via apt or manually depending on our options. :)

the usual Dockerfile for terrad binary can work with terraclassic.terrad-node image so I think it is more clean to keep one usuable Dockerfile

@ZaradarBH ZaradarBH added out of scope work that is unapproved by the community, but still essential for the L1 team enhancement New feature or request labels Mar 16, 2023
@ZaradarBH ZaradarBH added this to the Core - v2.0.0 milestone Mar 16, 2023
@nghuyenthevinh2000 nghuyenthevinh2000 marked this pull request as ready for review March 16, 2023 15:00
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM m8. A few suggestions, nothing critical :)

Makefile Show resolved Hide resolved
contrib/terra-operator/Dockerfile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ZaradarBH ZaradarBH merged commit 74bf5c4 into main Mar 18, 2023
@fragwuerdig fragwuerdig deleted the terra-operator-refactor branch May 25, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request out of scope work that is unapproved by the community, but still essential for the L1 team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants