Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testnet refactor #194

Merged
merged 11 commits into from
Mar 31, 2023
Merged

Testnet refactor #194

merged 11 commits into from
Mar 31, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

@nghuyenthevinh2000 nghuyenthevinh2000 commented Mar 27, 2023 •
edited
Loading

Summary of changes

  1. change testnet command to support arbitray node, add voting period to 30s
  2. update gh workflow accordingly (tested working on local machine)
  3. update upgrade script old version from 1.0.5 to 1.1.0
  4. 7 validators instead of 6 (4/3 so that we can reset 1 node, 7/3 so that we can reset 2 node without breaking consensus) (n > 3f) (n is total number of node, f is Byzantine number of node)
  5. specifically use minalloc v2.0.0 to ensure stability

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@nghuyenthevinh2000 nghuyenthevinh2000 marked this pull request as ready for review March 27, 2023 05:56
ZaradarBH
ZaradarBH reviewed Mar 27, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
contrib/localnet/deposit-test.sh Outdated Show resolved Hide resolved
contrib/localnet/deposit-test.sh Outdated Show resolved Hide resolved
contrib/updates/docker-compose.yml Show resolved Hide resolved
ZaradarBH
ZaradarBH approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nghuyenthevinh2000
Copy link
Contributor Author

nghuyenthevinh2000 commented Mar 30, 2023 •
edited
Loading

here is proof for successful upgrade running: https://github.com/classic-terra/core/actions/runs/4567709498/jobs/8061833155

everything should be ready to merge

fragwuerdig
fragwuerdig approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@fragwuerdig fragwuerdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues...

@nghuyenthevinh2000
Copy link
Contributor Author

I don't see any issues...

thanks man

@nghuyenthevinh2000 nghuyenthevinh2000 merged commit 8273b30 into main Mar 31, 2023
nghuyenthevinh2000 added a commit that referenced this pull request May 2, 2023
@nghuyenthevinh2000
Testnet refactor (#194)
30e0863
@fragwuerdig fragwuerdig deleted the testnet-refactor branch May 25, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fragwuerdig fragwuerdig fragwuerdig approved these changes

@ZaradarBH ZaradarBH Awaiting requested review from ZaradarBH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghuyenthevinh2000 @fragwuerdig @ZaradarBH