-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FeeDecorator #331
feat: FeeDecorator #331
Conversation
@inon-man I think it needs one more oracle submit tx test to make sure. Let's me add that one in |
One question. Does this |
fee is collected first from account to FeeCollector, then tax is get from FeeCollector |
Does this fully solve the calculation issues e.g. in terms of simulate endpoint requests? What effect does it have for contracts? |
@inon-man please check again before merge. I am all good. |
You can think this as a refactoring task. It does not change the behavior of the chain of Ante handlers. I migrated all the tests as well. |
In addition, DeductFee function sends fees from account to fee collector. |
Description
This PR adds a new Ante handler
FeeDecorator
that merges TaxFeeDecorator, BurnTaxFeeDecorator, and DeductFeeDecorator of CosmosSDK. This is required for allowing validators to submit oracle vote transactions without fee.Closes: #330