Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not BurnTaxSplit when simulating #340

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: do not BurnTaxSplit when simulating #340

merged 1 commit into from
Sep 4, 2023

Conversation

alchemist-ti
Copy link
Contributor

Summary of changes

Closes #335,

Terra-classic did not BurnTaxSplit in previous versions: https://github.com/classic-terra/core/blob/v2.1.1/custom/auth/ante/burntax.go#L51-L89.

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

inon-man
inon-man approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@inon-man inon-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inon-man inon-man assigned inon-man and alchemist-ti and unassigned inon-man Sep 4, 2023
@inon-man inon-man added the bug Something isn't working label Sep 4, 2023
@inon-man inon-man added this to the v2.2.0 milestone Sep 4, 2023
@inon-man inon-man changed the title Do not BurnTaxSplit when simulating fix: do not BurnTaxSplit when simulating Sep 4, 2023
@inon-man inon-man self-requested a review September 4, 2023 10:42
@inon-man inon-man merged commit f75ef44 into classic-terra:main Sep 4, 2023
15 checks passed
@alchemist-ti alchemist-ti deleted the revert-burntax-fee branch September 4, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inon-man inon-man inon-man approved these changes

Assignees

@alchemist-ti alchemist-ti

Labels
bug Something isn't working
Projects
No open projects
L1 Q3 Sprint
Status: ✅ Done
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

[BUG] misleading error messages with new tax handling
2 participants
@alchemist-ti @inon-man