handle excessive fee deduction during simulation #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbunproject
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
This code ensures that during transaction simulations, fees and taxes are accurately accounted for without causing deduction errors. If the provided fee doesn't cover the required taxes, it adjusts the fees within the simulation to meet the necessary amounts. These adjustments are only applied in the simulation environment, so real account balances remain unaffected. This approach helps reliably predict transaction outcomes and prevents failures when executing transactions for real.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As we need to deduct the fees and tax to be able to handle the gas estimations correctly, there is a deviation from the normal upstream behavior where only sent fees are deducted. This PR addresses that.
It is an endpoint change only (simulation mode only) and not relevant for consensus.