-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Reverse Charge tax approach #525
Open
StrathCole
wants to merge
21
commits into
main
Choose a base branch
from
strath/reverse-charge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use empty gas prices for sim tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is an implementation as an alternative to tax2gas.
It solves similar issues as tax2gas does, but additionally shifts taxation to the recipient side.
Also it removes double-taxation of contracts, i.e. contract calls are no longer taxed, but sending funds from inside contracts to the final wallet destination is.
Copilot Summary
This pull request introduces the integration of a new Tax module into the Terra blockchain application. The changes primarily involve adding the TaxKeeper to various parts of the application and ensuring it is properly initialized and utilized in transaction handling. Below is a summary of the most important changes:
Integration of Tax Module
TaxKeeper
to theAppKeepers
structure and initialized it in theNewAppKeepers
function inapp/keepers/keepers.go
. [1] [2]appModules
,simulationModules
,orderBeginBlockers
,orderEndBlockers
, andorderInitGenesis
inapp/modules.go
. [1] [2] [3] [4] [5]Changes in AnteHandler
HandlerOptions
andNewAnteHandler
incustom/auth/ante/ante.go
to include and check forTaxKeeper
. [1] [2]FeeDecorator
to account for taxes and handle scenarios where fees are insufficient to cover both gas and taxes incustom/auth/ante/fee.go
. [1] [2] [3]Import Statements
app/keepers/keepers.go
,app/modules.go
,custom/auth/ante/ante.go
, andcustom/auth/ante/fee.go
). [1] [2] [3] [4]Initialization and Configuration
NewAppKeepers
andinitParamsKeeper
functions inapp/keepers/keepers.go
. [1] [2]These changes collectively ensure that the new Tax module is fully integrated into the Terra blockchain application, with proper initialization, configuration, and handling within the transaction processing pipeline.