Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod additional metadata #440

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Pod additional metadata #440

merged 9 commits into from
Apr 22, 2024

Conversation

hamza-boudouche
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 401ee6a
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/6626618a8888a90008f7bb2f

@hamza-boudouche hamza-boudouche marked this pull request as draft April 19, 2024 09:52
@hamza-boudouche hamza-boudouche marked this pull request as ready for review April 19, 2024 10:17
prometherion
prometherion requested changes Apr 22, 2024
View reviewed changes
api/v1alpha1/tenantcontrolplane_types.go Outdated
Comment on lines 144 to 146
ExtraArgs *ControlPlaneExtraArgs `json:"extraArgs,omitempty"`
AdditionalMetadata AdditionalMetadata `json:"additionalMetadata,omitempty"`
PodAdditionalMetadata AdditionalMetadata `json:"podAdditionalMetadata,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ExtraArgs *ControlPlaneExtraArgs `json:"extraArgs,omitempty"`
AdditionalMetadata AdditionalMetadata `json:"additionalMetadata,omitempty"`
PodAdditionalMetadata AdditionalMetadata `json:"podAdditionalMetadata,omitempty"`
ExtraArgs *ControlPlaneExtraArgs `json:"extraArgs,omitempty"`
AdditionalMetadata AdditionalMetadata `json:"additionalMetadata,omitempty"`
PodAdditionalMetadata AdditionalMetadata `json:"podAdditionalMetadata,omitempty"`

Just a minor styling guide suggested by fmt

@prometherion
Copy link
Member

prometherion commented Apr 22, 2024 •
edited
Loading

Please, commit changes introduced with make yaml-installation-file and the ones required by make golint exceptions.

@hamza-boudouche
Copy link
Contributor Author

Please, commit changes introduced with make yaml-installation-file and the ones required by make golint exceptions.

Done

@prometherion prometherion added this to the v0.6.0 milestone Apr 22, 2024
@prometherion prometherion added the enhancement New feature or request label Apr 22, 2024
@prometherion prometherion changed the title Feat/pod-additional-metadata Pod additional metadata Apr 22, 2024
@prometherion prometherion merged commit d31b3ea into clastix:master Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza-boudouche @prometherion @x1e9