Supporting NATS as Datastore #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
prometherion
requested changes
Apr 19, 2024
thecodeassassin
commented
Apr 19, 2024
| @@ -867,6 +867,8 @@ func (d Deployment) buildKine(podSpec *corev1.PodSpec, tcp kamajiv1alpha1.Tenant | |||
| args["--endpoint"] = "mysql://$(DB_USER):$(DB_PASSWORD)@tcp($(DB_CONNECTION_STRING))/$(DB_SCHEMA)" | |||
| case kamajiv1alpha1.KinePostgreSQLDriver: | |||
| args["--endpoint"] = "postgres://$(DB_USER):$(DB_PASSWORD)@$(DB_CONNECTION_STRING)/$(DB_SCHEMA)" | |||
| case kamajiv1alpha1.KineNatsDriver: | |||
| args["--endpoint"] = "nats://$(DB_USER):$(DB_PASSWORD)@$(DB_CONNECTION_STRING)?bucket=$(DB_SCHEMA)" | |||
There was a problem hiding this comment.
So the problem lies here, these environment variables are currently generated per control plane.
done |
thecodeassassin
commented
Apr 19, 2024
prometherion
requested changes
Apr 19, 2024
Co-authored-by: Dario Tranchitella <dario@tranchitella.eu>
…roup/kamaji into feature/nats-integration
prometherion
requested changes
Apr 22, 2024
Done |
|
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add basic NATS support.
*** NOTE ***
In it's current state, this only adds single-tenant support for NATS as NATS currently does not have an easy programmatic way of managing users via their API.
implements #400