Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link inside of SortableElement breaks sort in FF #118

Closed
Moerphy opened this issue Jan 13, 2017 · 4 comments
Closed

Link inside of SortableElement breaks sort in FF #118

Moerphy opened this issue Jan 13, 2017 · 4 comments

Comments

@Moerphy
Copy link

Moerphy commented Jan 13, 2017

Testcase: https://jsfiddle.net/tz2daph1/1/
When clicking on the list item it works correctly, when clicking the link itself it only moves a short distance with the mouse, then stops moving until mouseup. And then it follows the mouse again like it would normally until the next mouseup event.

This only happens in Firefox 50 for me, works in all other major browsers.

@Moerphy
Copy link
Author

Moerphy commented Jan 16, 2017

Thanks for the fast fix! Seems like the bug still happens if the SortableContainer is using the distance property. I think moving the fix to handleStart instead of handlePress should fix that too.

https://jsfiddle.net/tz2daph1/2/

@clauderic
Copy link
Owner

Riiiiiight! Will fix shortly, sorry about that!

@clauderic
Copy link
Owner

Just pushed a fix to npm with 0.4.7, give it a spin and let me know if all is well!

@Moerphy
Copy link
Author

Moerphy commented Jan 17, 2017

Thanks, looks like it works perfectly now!

DimitarNestorov pushed a commit to codemotionapps/react-sortable-hoc that referenced this issue Feb 4, 2019
DimitarNestorov pushed a commit to codemotionapps/react-sortable-hoc that referenced this issue Feb 4, 2019
clauderic pushed a commit that referenced this issue Aug 21, 2019
* Fix firefox event issue related to Button tag

This is the same issue as #118 but it also applies to button on FF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants