Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add UTF-8 filename* in Content-Disposition #332

Merged

Conversation

YDX-2147483647
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 commented Jul 27, 2024

Fixes #331
Relates-to: #253

Result of qrcp send 啊.txt

Before:

Content-Disposition: "attachment; filename=\xe5\x95\x8a.txt"

After:

Content-Disposition: "attachment; filename=\"\xe5\x95\x8a.txt\"; filename*=UTF-8''%E5%95%8A.txt"

@claudiodangelis
Copy link
Owner

Hello, thanks for taking the time for this.
I'll have a look next week and release a new version with your change!

Claudio

@YDX-2147483647
Copy link
Contributor Author

Hi! Do you have time recently? This is a simple PR with context provided in #331. If you want to test but Safari is not available, maybe I can send a video to you?

Kindly ping @claudiodangelis

@claudiodangelis
Copy link
Owner

Apologies for the long wait, I'll try to find some time tomorrow.
Thanks!
C

@claudiodangelis
Copy link
Owner

I could not reproduce the original issue, but I trust your research.
Many thanks for taking the time for this, I'm preparing a new release now.
C

@claudiodangelis claudiodangelis self-requested a review September 1, 2024 14:16
@claudiodangelis claudiodangelis changed the base branch from main to release/0.11.3 September 1, 2024 14:25
@claudiodangelis claudiodangelis merged commit 3b803b1 into claudiodangelis:release/0.11.3 Sep 1, 2024
@YDX-2147483647 YDX-2147483647 deleted the utf-8 branch September 1, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filename is decoded wrongly on Safari
2 participants