Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom sort #1404

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Custom sort #1404

wants to merge 11 commits into from

Conversation

manuelurenah
Copy link
Contributor

Description

QA

NOTE: In order to test this feature, we need to npm link the new changes from amphora-search in branch update-page-mapping

  • Link this package to a clay instance with npm link
  • Create a couple of articles with different titles an authors
  • Verify that sorting is working correctly for title, byline and status
  • Collaborators field shouldn't be clickable

fxisco
fxisco reviewed May 8, 2019
View reviewed changes
lib/nav/page-list.vue Outdated Show resolved Hide resolved
lib/nav/page-list.vue Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 8, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 33.889% when pulling 89ce5b3 on custom-sort into e09e32d on master.

@manuelurenah manuelurenah mentioned this pull request May 9, 2019
Merged
pedro-rosario
pedro-rosario reviewed May 10, 2019
View reviewed changes
lib/nav/page-list.vue Outdated
scheduledTime: { order: 'desc' }
};

// also sort by scheduledlast scheduled time
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// also sort by scheduledlast scheduled time
// also sort by last scheduled time

@manuelurenah
Copy link
Contributor Author

Custom sort

Adds new component to show a sort by date dropdown (#1407)
89ce5b3 
* Adds new component to show a sort by date dropdown
* Applies PR code review feedback
* Moves styles at EOF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxisco fxisco fxisco approved these changes

@pedro-rosario pedro-rosario pedro-rosario approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@manuelurenah manuelurenah

Labels
blocked feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelurenah @coveralls @fxisco @pedro-rosario