This repository has been archived by the owner on May 6, 2020. It is now read-only.
agent: Update libcontainer and remove the reaper fix #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amshinde @jcvenegas please take a look. |
|
opencontainers/runc#1506 is the fix in libcontainer allowing this PR. |
|
@sboeuf you hit travis |
|
@GabyCT ping we will need to run your soak test. |
The latest version of libcontainer introduces a fix to reap the defunct child process so that we don't have to do that from our agent anymore. This is pretty logical since the lib is starting the process on our behalf, therefore they know they are leaving a zombie process behind us. Fixes #88 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
force-pushed
the
sboeuf/remove_reaper
branch
from
804e5f1
to
960d8db
Compare
|
@jcvenegas you can find the test at https://github.com/clearcontainers/tests/tree/master/integration/stability |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of libcontainer introduces a fix to reap the
defunct child process so that we don't have to do that from our
agent anymore.
This is pretty logical since the lib is starting the process on
our behalf, therefore they know they are leaving a zombie process
behind.
Fixes #88