Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Consider using more variables in template files #221

Open
jodh-intel opened this issue Dec 19, 2017 · 0 comments
Open

Consider using more variables in template files #221

jodh-intel opened this issue Dec 19, 2017 · 0 comments

Comments

@jodh-intel
Copy link

jodh-intel commented Dec 19, 2017

Each template file has a few fields that are repeated and which could be replaced by a variable (as done for things like @GO_VERSION@).

For example, the following is common to most of the rpm template files:

%global DOMAIN github.com
%global ORG clearcontainers

.. and again, most spec file templates contain things like:

%global PROJECT proxy
Name: cc-proxy

... which could be generated from the corresponding update_proxy.sh (or other update_*.sh script [*]).

This sort of refactoring is going to make maintaining these packages easier, ensures the metadata is consistent and would make it easy to rename the packages should we need to in the future.


[*] - It may even be possible to refactor all the update_*.sh scripts further so that more is pushed into ./scripts/pkglib.sh.

egernst pushed a commit to egernst/cc-packaging that referenced this issue Nov 26, 2018
kernel: configs: Add EFI support
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant