Make opensuse build #37
Conversation
|
Each of the commits updates multiple subsystems, like a6e9e1e. Any way to convince Travis to accept it anyway? |
|
@thiagomacieira Thanks a lot for this PR. The missing part on the commit and the PR is the word Fixes: You need to add Fixes #37 to make travis happy #37 is the issue I filed yesterday related to this. |
|
@thiagomacieira oh, and I noticed that you are trying to push 3 commits. Could you squash them in a single commit and add the issue the commit fixes (In this case #37 ) It is recommended that each of your patches fixes one thing, so in this case your 3 commits fixes one single issue. So better be in a single squashed commit. |
|
Well, each of the patches fixes one problem with the .spec files. Building for OpenSUSE wasn't a simple fix. Do you really want me to squash? |
|
@thiagomacieira oh, if each of the commits fixes an issue could you please create issuesand then reference the issue fixed in each of the commits as: Fixes: #XX |
|
On a closer look I found that travis is complaining that your commits does not have a
From https://github.com/clearcontainers/tests/tree/master/cmd/checkcommits
Could you try to rephrase the subject in your commits with something like:
|
Some are just things that the default image for OpenSUSE doesn't have, while the Fedora/CentOS/RHEL ones do. Some others are different package names compared to the Red Hat distributions. The %if trick was taken from https://en.opensuse.org/openSUSE:Build_Service_cross_distribution_howto Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
OpenSUSE has no /usr/libexec. Those go simply to /usr/lib. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
make-opensuse-build
branch
from
1a02e17 to
0ff113e
Compare
OpenSUSE requires the directories to be owned too, not just the files. I don't know if this is against Red Hat packaging guidelines, so I didn't use any %if. Fixes clearcontainers#36. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
make-opensuse-build
branch
from
0ff113e to
83f5502
Compare
|
lgtm |
Build qemu without librados. This allows build qemu in OBS. Fixes: clearcontainers#37 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
I've got OpenSUSE Tumbleweed building at https://build.opensuse.org/project/show/home:thiagomacieira:branches:home:clearcontainers:clear-containers-3-staging
Fixes #36