This repository has been archived by the owner on May 6, 2020. It is now read-only.
scripts: Add script to generate hypervisor configure options. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a proliferation of scripts and config files from specifying different sets of hypervisor configuration options, this script can be run to generate the correct set of options. Each option group has been documented explaining why it has been specified. The script currently only works for "qemu*" hypervisors but could be extended in the future. Fixes clearcontainers#339. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
There are a couple of |
|
once lgtm
|
We don't use the virtfs-proxy-helper(1) 9p helper binary, so disable it (and it's dependencies) using: --disable-virtfs --disable-attr --disable-cap-ng Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added some detail to scripts/configure-hypervisor.sh for "--disable-linux-aio". Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
add-qemu-build-options-script
branch
from
d4fba34 to
6b7009a
Compare
|
Replaced by clearcontainers/packaging#45. |
mcastelino
pushed a commit
to mcastelino/tests
that referenced
this pull request
Jan 23, 2019
…Cgroup integration/docker: add test for containers with parent cgroup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a proliferation of scripts and config files from specifying
different sets of hypervisor configuration options, this script can be
run to generate the correct set of options.
Each option group has been documented explaining why it has been specified.
The script currently only works for "qemu*" hypervisors but could be
extended in the future.
Fixes #339.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com