Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft OAuth guide; align copy about development vs production instances in other guides #1588

Merged
merged 20 commits into from
Oct 4, 2024

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Oct 2, 2024

Important

🔎 Previews:

Explanation:

This PR:

  • Updates the Microsoft guide according to the Microsoft portal and Clerk Dashboard updates
  • Adds instructions to the Microsoft guide on what to do about the checkboxes for access tokens and id tokens
  • Aligns copy about dev vs prod instances in other guides

Fixes DOCS-9311

@alexisintech alexisintech changed the title Aa/docs 9247 Update Microsoft OAuth guide Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1588

@alexisintech alexisintech changed the title Update Microsoft OAuth guide Update Microsoft OAuth guide; align copy about development vs production instances in other guides Oct 4, 2024
@alexisintech alexisintech marked this pull request as ready for review October 4, 2024 17:42
@alexisintech alexisintech requested a review from a team as a code owner October 4, 2024 17:42
@alexisintech alexisintech merged commit 5239e64 into main Oct 4, 2024
3 checks passed
@alexisintech alexisintech deleted the aa/DOCS-9247 branch October 4, 2024 17:58
Comment on lines 31 to 32
1. Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active?path=user-authentication/sso-connections).
1. In the top navigation, select **Configure**. Then in the sidebar, select **SSO Connections**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should condense this from
In the top navigation, select Configure. Then in the sidebar, select SSO Connections.
to
In your Clerk Dashboard, go to User & Authentication > SSO Connections.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then an unknowing user will click every tab at the top, and search the entire page looking for "User & Authentication". until they reach the fourth and final tab.
so I don't agree with this - I think because we don't use screenshots, and because we now have four entirely separate contexts, we should be very explicit when directing the user to what context they should be looking at ("configure").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair!

royanger pushed a commit that referenced this pull request Oct 8, 2024
…ion instances in other guides (#1588)

Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants