fix(clerk-js): Remove leftover strings in SignInStart and SignUpStart

clerk · Jul 12, 2023 · 0a7a889 · 0a7a889
1 parent cf91866
commit 0a7a889
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/.changeset/fifty-keys-burn.md b/.changeset/fifty-keys-burn.md
@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Fixed a bug where overriding some localization values in the sign in/up start pages with an empty string would result in showing the english translation.
diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
@@ -278,22 +278,18 @@ export function _SignInStart(): JSX.Element {
                   />
                 </Form.ControlRow>
                 <InstantPasswordRow field={passwordBasedInstance ? instantPasswordField : undefined} />
-                <Form.SubmitButton>Continue</Form.SubmitButton>
+                <Form.SubmitButton />
               </Form.Root>
             ) : null}
           </SocialButtonsReversibleContainerWithDivider>
         </Col>
         <Footer.Root>
           <Footer.Action elementId='signIn'>
-            <Footer.ActionText localizationKey={localizationKeys('signIn.start.actionText')}>
-              No account?
-            </Footer.ActionText>
+            <Footer.ActionText localizationKey={localizationKeys('signIn.start.actionText')} />
             <Footer.ActionLink
               localizationKey={localizationKeys('signIn.start.actionLink')}
               to={clerk.buildUrlWithAuth(signUpUrl)}
-            >
-              Sign up
-            </Footer.ActionLink>
+            />
           </Footer.Action>
           <Footer.Links />
         </Footer.Root>

diff --git a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
@@ -240,10 +240,8 @@ function _SignUpStart(): JSX.Element {
       <Card>
         <CardAlert>{card.error}</CardAlert>
         <Header.Root>
-          <Header.Title localizationKey={localizationKeys('signUp.start.title')}>Create your account</Header.Title>
-          <Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')}>
-            to continue to {displayConfig.applicationName}
-          </Header.Subtitle>
+          <Header.Title localizationKey={localizationKeys('signUp.start.title')} />
+          <Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')} />
         </Header.Root>
         <Flex
           direction='col'
@@ -271,9 +269,7 @@ function _SignUpStart(): JSX.Element {
         </Flex>
         <Footer.Root>
           <Footer.Action elementId='signUp'>
-            <Footer.ActionText localizationKey={localizationKeys('signUp.start.actionText')}>
-              Have an account?
-            </Footer.ActionText>
+            <Footer.ActionText localizationKey={localizationKeys('signUp.start.actionText')} />
             <Footer.ActionLink
               localizationKey={localizationKeys('signUp.start.actionLink')}
               to={clerk.buildUrlWithAuth(signInUrl)}