chore(clerk-js): Clean up props for SignInFactorOnePassword (#4032)

clerk · Aug 27, 2024 · b20e28b · b20e28b
1 parent 6428493
commit b20e28b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/.changeset/slimy-students-wonder.md b/.changeset/slimy-students-wonder.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOne.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOne.tsx
@@ -1,4 +1,4 @@
-import type { ResetPasswordCodeFactor, SignInFactor } from '@clerk/types';
+import type { SignInFactor } from '@clerk/types';
 import React from 'react';
 
 import { withRedirectToAfterSignIn } from '../../common';
@@ -134,15 +134,6 @@ export function _SignInFactorOne(): JSX.Element {
     case 'password':
       return (
         <SignInFactorOnePasswordCard
-          onFactorPrepare={(factor: ResetPasswordCodeFactor) => {
-            handleFactorPrepare();
-            setFactor(prev => ({
-              currentFactor: {
-                ...factor,
-              },
-              prevCurrentFactor: prev.currentFactor,
-            }));
-          }}
           onForgotPasswordMethodClick={resetPasswordFactor ? toggleForgotPasswordStrategies : toggleAllStrategies}
           onShowAlternativeMethodsClick={toggleAllStrategies}
           onPasswordPwned={() => {

diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx
@@ -1,6 +1,5 @@
 import { isPasswordPwnedError, isUserLockedError } from '@clerk/shared/error';
 import { useClerk } from '@clerk/shared/react';
-import type { ResetPasswordCodeFactor } from '@clerk/types';
 import React from 'react';
 
 import { clerkInvalidFAPIResponse } from '../../../core/errors';
@@ -16,7 +15,6 @@ import { useResetPasswordFactor } from './useResetPasswordFactor';
 type SignInFactorOnePasswordProps = {
   onForgotPasswordMethodClick: React.MouseEventHandler | undefined;
   onShowAlternativeMethodsClick: React.MouseEventHandler | undefined;
-  onFactorPrepare: (f: ResetPasswordCodeFactor) => void;
   onPasswordPwned?: () => void;
 };
 

diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorTwo.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorTwo.tsx
@@ -32,7 +32,6 @@ export function _SignInFactorTwo(): JSX.Element {
   const [showAllStrategies, setShowAllStrategies] = React.useState<boolean>(!currentFactor);
   const toggleAllStrategies = () => setShowAllStrategies(s => !s);
 
-  // TODO
   const handleFactorPrepare = () => {
     lastPreparedFactorKeyRef.current = factorKey(currentFactor);
   };