Skip to content

Commit

Permalink
feat(clerk-js): Omit routing prop from Modal components
Browse files Browse the repository at this point in the history
  • Loading branch information
octoper committed Nov 8, 2023
1 parent 00477d4 commit c90d57e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const CreateOrganization = withOrganizationsEnabledGuard(
{ mode: 'redirect' },
);

export const CreateOrganizationModal = (props: Omit<CreateOrganizationProps, 'path'>): JSX.Element => {
export const CreateOrganizationModal = (props: Omit<CreateOrganizationProps, 'path' | 'routing'>): JSX.Element => {
const createOrganizationProps: CreateOrganizationCtx = {
...props,
routing: 'virtual',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const OrganizationProfile = withRedirectToHomeOrganizationGuard(
}),
);

export const OrganizationProfileModal = (props: Omit<OrganizationProfileProps, 'path'>): JSX.Element => {
export const OrganizationProfileModal = (props: Omit<OrganizationProfileProps, 'path' | 'routing'>): JSX.Element => {
const organizationProfileProps: OrganizationProfileCtx = {
...props,
routing: 'virtual',
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/components/SignIn/SignIn.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ SignInRoutes.displayName = 'SignIn';

export const SignIn: React.ComponentType<SignInProps> = withCoreSessionSwitchGuard(SignInRoutes);

export const SignInModal = (props: Omit<SignInProps, 'path'>): JSX.Element => {
export const SignInModal = (props: Omit<SignInProps, 'path' | 'routing'>): JSX.Element => {
const signInProps = {
signUpUrl: `/${VIRTUAL_ROUTER_BASE_PATH}/sign-up`,
...props,
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/components/SignUp/SignUp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ SignUpRoutes.displayName = 'SignUp';

export const SignUp: React.ComponentType<SignUpProps> = withCoreSessionSwitchGuard(SignUpRoutes);

export const SignUpModal = (props: Omit<SignUpProps, 'path'>): JSX.Element => {
export const SignUpModal = (props: Omit<SignUpProps, 'path' | 'routing'>): JSX.Element => {
const signUpProps = {
signInUrl: `/${VIRTUAL_ROUTER_BASE_PATH}/sign-in`,
...props,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const AuthenticatedRoutes = withCoreUserGuard(() => {

export const UserProfile = withRedirectToHomeUserGuard(withCardStateProvider(_UserProfile));

export const UserProfileModal = (props: Omit<UserProfileProps, 'path'>): JSX.Element => {
export const UserProfileModal = (props: Omit<UserProfileProps, 'path' | 'routing'>): JSX.Element => {
const userProfileProps: UserProfileCtx = {
...props,
routing: 'virtual',
Expand Down

0 comments on commit c90d57e

Please sign in to comment.