Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node SDK: createUser function missing createdAt property #2281

Closed
4 tasks done
mboudreau opened this issue Dec 7, 2023 · 1 comment
Closed
4 tasks done

Node SDK: createUser function missing createdAt property #2281

mboudreau opened this issue Dec 7, 2023 · 1 comment
Assignees
@dimkl
Labels
prioritized This issue has been triaged and the team is working on it

Comments

@mboudreau
Copy link

Preliminary Checks

Reproduction / Replay Link

https://github.com/clerk/javascript/blob/main/packages/backend/src/api/endpoints/UserApi.ts#L59

Publishable key

not needed

Description

Steps to reproduce:

  1. Install @clerk/clerk-node-sdk@4.12.23
  2. Try to use createUser function to create a user with a createdAt date
  3. Typescript error happens. Try same object with updateUser function, createdAt date works.

Expected behavior:

The API allows for a created_at option to be specified for new users, but the backend SDK does not allow this property on the createUser function because of the lack of this property signature. It's not a problem with the updateUser function however.

Actual behavior:

Typescript failure on adding createdAt property to createUser function.

Environment

no need
@mboudreau mboudreau added the needs-triage A ticket that needs to be triaged by a team member label Dec 7, 2023
@dimkl dimkl self-assigned this Dec 7, 2023
dimkl added a commit that referenced this issue Dec 7, 2023
@dimkl
fix(backend): Add createdAt param in User#createUser request
0760a02 
Resolves #2281
@dimkl dimkl mentioned this issue Dec 7, 2023
Merged
24 tasks
@dimkl dimkl added prioritized This issue has been triaged and the team is working on it and removed needs-triage A ticket that needs to be triaged by a team member labels Dec 7, 2023
dimkl added a commit that referenced this issue Dec 7, 2023
@dimkl
fix(backend): Add createdAt param in User#createUser request
feaa241 
Resolves #2281
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2023
@dimkl
fix(backend,clerk-sdk-node): Resolve reported signature issues (#2284)
7af0949 
* fix(backend): Add `createdAt` param in User#createUser request

Resolves #2281

* fix(clerk-sdk-node): Fix `verifyToken()` signature to support a signle token param

Resolves #2280

* chore(repo): Add changeset
dimkl added a commit that referenced this issue Dec 7, 2023
@dimkl
fix(backend,clerk-sdk-node): Resolve reported signature issues (#2284)
abd8408 
* fix(backend): Add `createdAt` param in User#createUser request

Resolves #2281

* fix(clerk-sdk-node): Fix `verifyToken()` signature to support a signle token param

Resolves #2280

* chore(repo): Add changeset

(cherry picked from commit 7af0949)
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2023
@dimkl
fix(backend,clerk-sdk-node): Resolve reported signature issues (#2284) (
c7763fa 
#2288)

* fix(backend): Add `createdAt` param in User#createUser request

Resolves #2281

* fix(clerk-sdk-node): Fix `verifyToken()` signature to support a signle token param

Resolves #2280

* chore(repo): Add changeset

(cherry picked from commit 7af0949)
@dimkl
Copy link
Contributor

dimkl commented Dec 7, 2023

Hello @mboudreau
thank you for reporting this. A fix has been released as part of @clerk/clerk-sdk-node@4.13.0

@dimkl dimkl closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimkl dimkl

Labels
prioritized This issue has been triaged and the team is working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mboudreau @dimkl