feat(remix): Support v2_errorBoundary future flag
#1444
Conversation
🦋 Changeset detectedLatest commit: bdc474a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
|
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.20-snapshot.6b46a7e# @clerk/clerk-js
npm i @clerk/clerk-js@4.51.1-snapshot.6b46a7e# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.11-snapshot.6b46a7e# @clerk/fastify
npm i @clerk/fastify@0.5.6# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19# @clerk/localizations
npm i @clerk/localizations@1.22.0# @clerk/nextjs
npm i @clerk/nextjs@4.21.13# @clerk/clerk-react
npm i @clerk/clerk-react@4.21.1# @clerk/remix
npm i @clerk/remix@2.6.16# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1 |
anagstef
force-pushed
the
stefanos/js-278-spike-support-remixv2
branch
from
6b46a7e
to
356787e
Compare
|
!snapshot |
|
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.20-snapshot.356787e# @clerk/clerk-js
npm i @clerk/clerk-js@4.51.1-snapshot.356787e# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.11-snapshot.356787e# @clerk/fastify
npm i @clerk/fastify@0.5.6# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19# @clerk/localizations
npm i @clerk/localizations@1.22.0# @clerk/nextjs
npm i @clerk/nextjs@4.21.13# @clerk/clerk-react
npm i @clerk/clerk-react@4.21.1# @clerk/remix
npm i @clerk/remix@2.7.0-snapshot.356787e# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14# @clerk/shared
npm i @clerk/shared@0.19.1# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.46.1 |
| /* | ||
| * V2_ClerkErrorBoundary needs the `v2_errorBoundary` future flag to be enabled. | ||
| */ | ||
| export function V2_ClerkErrorBoundary(RootErrorBoundary?: React.ComponentType) { |
There was a problem hiding this comment.
@anagstef What is the difference between v1 CatchBoundary and v2 ErrorBoundary?
EDIT:
In v1, a thrown Response will render the closest CatchBoundary while all other unhandled exceptions render the ErrorBoundary. In v2 there is no CatchBoundary and all unhandled exceptions will render the ErrorBoundary, response or otherwise.
https://remix.run/docs/en/main/pages/v2#catchboundary-and-errorboundary
There was a problem hiding this comment.
In V2 the CatchBoundary is removed and all the errors end up in the ErrorBoundary. A helper with the name isRouteErrorResponse helps you identify if the error was an expected error (4xx) or an unexpected error.
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This PR introduces
V2_ClerkErrorBoundaryto supportv2_errorBoundaryfuture flagUsers that have enabled the
v2_errorBoundaryfuture flag need to useV2_ClerkErrorBoundaryin theirroot.tsxpage: