feat(clerk-js): Add tabs to VerifiedDomainPage #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
🦋 Changeset detectedLatest commit: 24eb5ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.28.0-snapshot.b7ea7af# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.27-snapshot.b7ea7af# @clerk/clerk-js
npm i @clerk/clerk-js@4.56.0-snapshot.b7ea7af# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.18-snapshot.b7ea7af# @clerk/fastify
npm i @clerk/fastify@0.6.4-snapshot.b7ea7af# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.5-snapshot.b7ea7af# @clerk/localizations
npm i @clerk/localizations@1.25.0-snapshot.b7ea7af# @clerk/nextjs
npm i @clerk/nextjs@4.23.3-snapshot.b7ea7af# @clerk/clerk-react
npm i @clerk/clerk-react@4.24.0-snapshot.b7ea7af# @clerk/remix
npm i @clerk/remix@2.10.0-snapshot.b7ea7af# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.3-snapshot.b7ea7af# @clerk/shared
npm i @clerk/shared@0.22.0-snapshot.b7ea7af# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.50.0-snapshot.b7ea7af |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.28.0-snapshot.12da27f# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.27-snapshot.12da27f# @clerk/clerk-js
npm i @clerk/clerk-js@4.56.0-snapshot.12da27f# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.18-snapshot.12da27f# @clerk/fastify
npm i @clerk/fastify@0.6.4-snapshot.12da27f# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.5-snapshot.12da27f# @clerk/localizations
npm i @clerk/localizations@1.25.0-snapshot.12da27f# @clerk/nextjs
npm i @clerk/nextjs@4.23.3-snapshot.12da27f# @clerk/clerk-react
npm i @clerk/clerk-react@4.24.0-snapshot.12da27f# @clerk/remix
npm i @clerk/remix@2.10.0-snapshot.12da27f# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.3-snapshot.12da27f# @clerk/shared
npm i @clerk/shared@0.22.0-snapshot.12da27f# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.50.0-snapshot.12da27f |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.28.0-snapshot.2d40f12# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.27-snapshot.2d40f12# @clerk/clerk-js
npm i @clerk/clerk-js@4.56.0-snapshot.2d40f12# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.18-snapshot.2d40f12# @clerk/fastify
npm i @clerk/fastify@0.6.4-snapshot.2d40f12# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.5-snapshot.2d40f12# @clerk/localizations
npm i @clerk/localizations@1.25.0-snapshot.2d40f12# @clerk/nextjs
npm i @clerk/nextjs@4.23.3-snapshot.2d40f12# @clerk/clerk-react
npm i @clerk/clerk-react@4.24.0-snapshot.2d40f12# @clerk/remix
npm i @clerk/remix@2.10.0-snapshot.2d40f12# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.3-snapshot.2d40f12# @clerk/shared
npm i @clerk/shared@0.22.0-snapshot.2d40f12# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.50.0-snapshot.2d40f12 |
nikosdouvlis
approved these changes
Aug 24, 2023
| @@ -60,7 +66,8 @@ export const RemoveDomainPage = () => { | |||
| successMessage={localizationKeys('organizationProfile.removeDomainPage.successMessage', { | |||
| domain: ref.current?.name, | |||
| })} | |||
| deleteResource={() => Promise.resolve(domain?.delete())} | |||
| deleteResource={() => Promise.resolve(domain?.delete()).then((domains as any).unstable__mutate())} | |||
There was a problem hiding this comment.
Is domain?.delete a sync method?
| }); | ||
| const { navigateToFlowStart } = useNavigateToFlowStart(); | ||
| const { params, navigate, queryParams } = useRouter(); | ||
| const mode = (queryParams.mode ?? 'edit') as 'select' | 'edit'; |
There was a problem hiding this comment.
Suggested change
| const mode = (queryParams.mode ?? 'edit') as 'select' | 'edit'; | |
| const mode = (queryParams.mode ||'edit') as 'select' | 'edit'; |
If we don't care about null, undefined or 0 specifically, let's prefer a plain || otherwise this reads like the falsy values have significant meaning
There was a problem hiding this comment.
Also, are you aware whether we use this queryParams pattern in the rest of the codebase?
There was a problem hiding this comment.
Here's how we did it for the reset password flow. This was implemented by me as well.
Are we considering this a bad pattern ?
panteliselef
changed the title
panteliselef
force-pushed
the
ORG-165
branch
2 times, most recently
from
e642012
to
c1219e5
Compare
panteliselef
changed the title
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This PR
-when visiting a verified domain within the addition or verify flow limit the action the user can do