chore(nextjs): Drop deprecations #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a47baa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
sdk-782-drop-deprecations-nextjs
branch
2 times, most recently
from
9c16e35
to
a7c014f
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-nextjs
branch
from
a7c014f
to
a47baa2
Compare
24 tasks
anagstef
approved these changes
Nov 3, 2023
| '@clerk/nextjs': major | ||
| --- | ||
|
|
||
| Drop deprecations. Migration steps: |
There was a problem hiding this comment.
@dimkl Should we mark these as breaking?
There was a problem hiding this comment.
I thought that the major version bump should indicate that but we can also mark them as breaking changes. All the changes with major version are breaking. What do you think?
There was a problem hiding this comment.
Merging this to continue with the cleanup and i will update the changeset if we want to somehow mark the changes as breaking.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop deprecations. Migration steps:
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEYinstead ofNEXT_PUBLIC_CLERK_FRONTEND_APIenv variableNEXT_PUBLIC_CLERK_JS_VERSIONinstead ofCLERK_JS_VERSIONCLERK_SECRET_KEYinstead ofCLERK_API_KEYpublishableKeyinstead offrontendApiisEmailLinkErrorinstead ofisMagicLinkErrorEmailLinkErrorCodeinstead ofMagicLinkErrorCodeuseEmailLinkinstead ofuseMagicLink@clerk/nextjsinstead of@clerk/nextjs/app-beta@clerk/nextjsinstead of@clerk/nextjs/ssr@clerk/nextjsinstead of@clerk/nextjs/edge-middlewareor@clerk/nextjs/edge-middlewarefilesauthMiddlewareinstead ofwithClerkMiddlewareAPI_URL,API_VERSION,CLERK_JS_URL,CLERK_JS_VERSION,DOMAIN,IS_SATELLITE,PROXY_URL,PUBLISHABLE_KEY,SECRET_KEY,SIGN_IN_URL,SIGN_UP_URLExtra:
@clerk/clerk-sdk-nodedependency as there is no use anymoreChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore