Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clerk-js): Emit session when permissions or role of the active memberships change #2073

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix(clerk-js): Emit session when permissions or role of the active memberships change #2073

merged 2 commits into from
Nov 8, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Nov 7, 2023 •
edited
Loading

Description

This PR allows for clerk-js to detect when the role or permissions of the active organization memberships of the user has changed and emit them for subscribers (in this case clerk-react is what we are interested in).

Before

not.working.mov

After

works.mov

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@panteliselef panteliselef self-assigned this Nov 7, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e1c5144

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef changed the title [WIP] fix(clerk-js): Emit session when permissions or role of the active me… fix(clerk-js): Emit session when permissions or role of the active memberships change Nov 8, 2023
@panteliselef panteliselef marked this pull request as ready for review November 8, 2023 09:37
@panteliselef panteliselef requested a review from a team as a code owner November 8, 2023 09:37
octoper
octoper approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselef panteliselef added this pull request to the merge queue Nov 8, 2023
dimkl
dimkl reviewed Nov 8, 2023
View reviewed changes
packages/clerk-js/src/core/resources/Organization.ts
method: 'GET',
search: convertPageToOffset(getRolesParams) as any,
}).then(res => {
return await BaseResource._fetch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 i think there is no need to return await in an async function. this PR didn't change the existing codebase but i think we should jest return the promise. This is a suggestion for the future.

dimkl
dimkl reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@dimkl dimkl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ @panteliselef Why do we need to pass forceUpdateClient? Isn't this change gonna force the re-rendering of all the Clerk components? Are we sure we want to use the forceUpdateClient to all those places?

Merged via the queue into main with commit 5f49568 Nov 8, 2023
6 checks passed
@panteliselef panteliselef deleted the elef/SDK-893-issues-with-gate branch November 8, 2023 11:06
@clerk-cookie clerk-cookie mentioned this pull request Nov 8, 2023
Merged
@panteliselef
Copy link
Member Author

❓ @panteliselef Why do we need to pass forceUpdateClient? Isn't this change gonna force the re-rendering of all the Clerk components? Are we sure we want to use the forceUpdateClient to all those places?

My understanding is that these changes will only affect the rerender of components if the conditions inside memoizeStateListenerCallback are met, which is ok and what we should do.

Even if forceUpdateClient and the new client object has not changes this will not force the re-rendering of all components.

panteliselef added a commit that referenced this pull request Nov 8, 2023
@panteliselef
fix(clerk-js): Emit session when permissions or role of the active me…
9b69f5f 
…mberships change (#2073)

* fix(clerk-js): Emit session when permissions or role of the active memberships change

* chore(clerk-js): Add changeset

(cherry picked from commit 5f49568)
@clerk-cookie clerk-cookie mentioned this pull request Nov 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2023
@clerk-cookie @panteliselef
fix(clerk-js): Emit session when permissions or role of the active me…
906da4f 
…mberships change (#2073) (#2081)

* fix(clerk-js): Emit session when permissions or role of the active memberships change

* chore(clerk-js): Add changeset

(cherry picked from commit 5f49568)

Co-authored-by: panteliselef <panteliselef@outlook.com>
@LekoArts LekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArts LekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkl dimkl dimkl approved these changes

@octoper octoper octoper approved these changes

Assignees

@panteliselef panteliselef

Labels
clerk-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panteliselef @dimkl @octoper @clerk-cookie