-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Support handshake flow for remix #2380
Conversation
🦋 Changeset detectedLatest commit: 6e4aa1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much all that's needed :)
We might need to do something in ssr/getAuth
as well. I did replace the error thrown in a previous PR with a redirect('') but could you please check whether we need something more or not? (and remove the todo ofc)
We want to halt execution in the nested loaders as all loaders (nested and root) run in parallel - we halt execution by throwing a redirect or an error. Remix evaluates errors first, so we should test that calling redirect
with ''
does indeed throw a redirect and not an error because of the invalid URL
.changeset/itchy-chairs-call.md
Outdated
'@clerk/remix': minor | ||
--- | ||
|
||
Update the Remix rootAuthLoader to handle handshake auth status, this replaces the previous interstitial flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include a short migration guide as the ClerkErrorBoundary export is no longer needed :)
…into authenticateRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
Description
Support the handshake flow for Remix.
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore