Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add support for X/Twitter v2 OAuth provider #2690

Merged

Conversation

kostaspt
Copy link
Member

@kostaspt kostaspt commented Jan 30, 2024

Description

Add required types for X/Twitter v2.

image

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 972de83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Minor
@clerk/backend Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/clerk-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kostaspt kostaspt force-pushed the kostas/core-1563-introduce-twitter-v2-types-in-clerkjs branch 2 times, most recently from 8096a8f to 5bebd29 Compare January 31, 2024 11:52
@kostaspt
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @kostaspt - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 1.0.1-snapshot.v5bebd29
@clerk/chrome-extension 1.0.1-snapshot.v5bebd29
@clerk/clerk-js 5.0.1-snapshot.v5bebd29
@clerk/clerk-expo 1.0.1-snapshot.v5bebd29
@clerk/fastify 1.0.1-snapshot.v5bebd29
gatsby-plugin-clerk 5.0.1-snapshot.v5bebd29
@clerk/localizations 2.0.1-snapshot.v5bebd29
@clerk/nextjs 5.0.1-snapshot.v5bebd29
@clerk/clerk-react 5.0.1-snapshot.v5bebd29
@clerk/remix 4.0.1-snapshot.v5bebd29
@clerk/clerk-sdk-node 5.0.1-snapshot.v5bebd29
@clerk/shared 2.0.1-snapshot.v5bebd29
@clerk/themes 2.0.1-snapshot.v5bebd29
@clerk/types 4.0.1-snapshot.v5bebd29

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.v5bebd29 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.v5bebd29 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.v5bebd29 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.v5bebd29 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.v5bebd29 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.v5bebd29 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.v5bebd29 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.v5bebd29 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.v5bebd29 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.v5bebd29 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v5bebd29 --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.v5bebd29 --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.v5bebd29 --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.v5bebd29 --save-exact

@clerk clerk deleted a comment from clerk-cookie Jan 31, 2024
@kostaspt kostaspt marked this pull request as ready for review January 31, 2024 15:34
Copy link
Member

@chanioxaris chanioxaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

'@clerk/types': patch
---

Add support for X/Twitter v2 OAuth provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 i would expect it to be a minor version change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I wasn't sure about this. ✅ Updated

@kostaspt kostaspt force-pushed the kostas/core-1563-introduce-twitter-v2-types-in-clerkjs branch from 5bebd29 to 62c90c7 Compare January 31, 2024 16:20
@kostaspt kostaspt force-pushed the kostas/core-1563-introduce-twitter-v2-types-in-clerkjs branch from 62c90c7 to 972de83 Compare January 31, 2024 16:23
@kostaspt kostaspt added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 7f751c4 Jan 31, 2024
7 checks passed
@kostaspt kostaspt deleted the kostas/core-1563-introduce-twitter-v2-types-in-clerkjs branch January 31, 2024 16:42
kostaspt added a commit that referenced this pull request Jan 31, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
(cherry picked from commit 7f751c4)

Co-authored-by: Konstantinos Pittas <konstantinos@clerk.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants