-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): Add orderBy to GetOrganizationListParams #3164
feat(backend): Add orderBy to GetOrganizationListParams #3164
Conversation
🦋 Changeset detectedLatest commit: 19bbbc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀 Thank for the contribution.
I will open an internal ticket so we can also add/update the orderBy
parameter in the following endpoints but feel free to open a PR for those 2 and i will review it:
- https://clerk.com/docs/reference/backend-api/tag/Organization-Memberships#operation/ListOrganizationMemberships!in=query&path=order_by&t=request
- https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUserList!in=query&path=order_by&t=request
PS: this change will be added to the latest beta version. In order to backport this to the current latest version you need to open a PR with release/v4
as base branch but since we will release the beta version as stable soon, i would consider using the latest beta
instead. For beta docs visit: https://beta.clerk.com/docs
@dimkl it looks like you have to approve the running of the GitHub workflows, before I'm able to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
@IGassmann even if i approve it, the actions won't run. Nikos will merge it :) |
We have a few GH variables that cannot be shared with forked repos - we will most liekly push the fix this week, so I will manually merge and run CICD for now :) Thank you for your contribution! |
Description
This adds the
orderBy
parameter toGetOrganizationListParams
.The
getOrganizationList
method in theOrganizationApi
was missing theorderBy
parameter, as @mario-jerkovic correctly pointed out in https://github.com/orgs/clerk/discussions/3152.The related documentation PR: clerk/clerk-docs#891
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change