-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js): Fallback to invisible CAPTCHA if the element is not found #3191
feat(clerk-js): Fallback to invisible CAPTCHA if the element is not found #3191
Conversation
…r to is not found in the DOM
🦋 Changeset detectedLatest commit: 0b7d139 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ How did the captchaPublicKeyInvisible
was populated up until now? Wasn;t the invisible
mode the default up until now?
I am mostly asking because it seems that this is a fix, not a feat :/
@dimkl you are right, the default one until now was Invisible. This |
I'm confused as to why we need 2 site keys at the same time. Don't we already know how to use a sitekey of type invisible ? |
@panteliselef The |
…isible-turnstile-clerkjs
Description
This PR:
captcha_public_key_invisible
CAPTCHA key alongside with the main key, so it can fallback toinvisible
CAPTCHA if theclerk-captcha
element is not found in the DOM.unsupported-callback
prop of the CF Turnstile, to show error when the browser is not supported.captcha_widget_type
prop in the/sign_ups
POST request to FAPI to let it know what widget type was used.always_visible
widget type option.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change