Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Fix Hungarian language subpath exports #3206

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

anagstef
Copy link
Member

Description

This is needed so developers can import from @clerk/localizations/hu-HU

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 8b67e9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis nikosdouvlis merged commit 2b8fe23 into main Apr 17, 2024
10 checks passed
@nikosdouvlis nikosdouvlis deleted the fix-huHU-subpaths branch April 17, 2024 08:21
@dimkl
Copy link
Contributor

dimkl commented Apr 17, 2024

Nice catch!!
It seems there the "mn-MN" is missing from the packages/localizations/src/index.ts and the "ca-ES", "nl-BE" from the packages/localizations/src/utils/generate.ts.
I think we should refactor our current set-up and avoid having all the references.
cc: @nikosdouvlis , @anagstef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants