fix(remix): Deprecate loadUser, loadSession and loadOrganization on rootAuthLoader
#3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 150f20f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🪛 I think it would be better to mark them as deprecated for now and drop them in the next major release of the SDK |
…ootAuthLoader options
anagstef
force-pushed
the
stefanos/sdk-1775-rootauthloader-rate-limit
branch
from
69d05fc
to
d48eb37
Compare
anagstef
changed the title
loadUser, loadSession and loadOrganization from rootAuthLoaderloadUser, loadSession and loadOrganization on rootAuthLoader
@octoper Agreed! Just pushed! |
panteliselef
approved these changes
May 26, 2024
|
@panteliselef Yes, we should have removed them. |
desiprisg
approved these changes
May 27, 2024
Co-authored-by: George Desipris <73396808+desiprisg@users.noreply.github.com>
|
I think we should also use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rootAuthLoadertypes suggest the usage ofloadUser,loadSessionandloadOrganizationboolean options. Using any of these will result to a call to Clerk Backend API on each root loader execution. This results in rate limiting issues for apps with many users and affects scalability.This PR deprecates these 3 options so that they're not misused.
Relevant issue: #1043
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change