Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(localizations): Localization of the Italian translation #3608

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

mazzasaverio
Copy link
Contributor

Description

This pull request addresses the incomplete localization fields for the Italian language in the @clerk/localizations package, which currently leads to unclear error messages when Italian users enter passwords that do not meet the requirements during registration. The issue specifically affects the presentation of error messages, reducing them to a red dot without explanatory text, as outlined by the interactions with Saverio Mazza who reported this inconsistency.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • JSDoc comments have been added or updated for any package exports.
  • Documentation has been updated.

Type of change

  • 🐛 Bug fix

Testing Instructions

  1. Update the Italian localization fields as per the changes in this PR.
  2. Run the application using npm start or similar command specific to the project.
  3. Navigate to the registration form and attempt to enter a password that fails to meet the requirements.
  4. Verify that the error messages are displayed in full text (not just a red dot) and are understandable to Italian users.

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 6cc35eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski tmilewski changed the title FIX: Localization of the Italian translation chore(localizations): Localization of the Italian translation Jun 25, 2024
@tmilewski tmilewski self-requested a review June 25, 2024 15:08
@tmilewski
Copy link
Member

@mazzasaverio Thanks a lot! Pushing through given expected E2E issues for external contributions.

@tmilewski tmilewski merged commit 7288832 into clerk:main Jun 25, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants