-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elements,ui): Add support for password error localization #3812
Merged
dstaley
merged 15 commits into
main
from
alexcarpenter/sdki-155-unable-to-translate-fieldstate-with-codes-setup
Aug 2, 2024
Merged
feat(elements,ui): Add support for password error localization #3812
dstaley
merged 15 commits into
main
from
alexcarpenter/sdki-155-unable-to-translate-fieldstate-with-codes-setup
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce4a4c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
reviewed
Jul 25, 2024
tmilewski
approved these changes
Jul 25, 2024
9 tasks
…nt config entries (#3847) Co-authored-by: Bryce Kalow <bryce@clerk.dev>
tmilewski
approved these changes
Aug 2, 2024
…ieldstate-with-codes-setup
alexcarpenter
changed the title
feat(ui): Add support for password localization
feat(elements,ui): Add support for password localization
Aug 2, 2024
alexcarpenter
changed the title
feat(elements,ui): Add support for password localization
feat(elements,ui): Add support for password error localization
Aug 2, 2024
dstaley
deleted the
alexcarpenter/sdki-155-unable-to-translate-fieldstate-with-codes-setup
branch
August 2, 2024 20:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
codes
argument to the render prop for<Common.FieldState>
containing error codes corresponding to failed validations. This allows consumers to generate appropriate error messages based on the provided codes.It also updates our UI package to demonstrate usage of the
codes
prop to generate localized error messages.Screenshots
Checklist
npm test
runs as expected.npm run build
runs as expected.FieldState
config
field clerk-docs#1330)Type of change