-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix): Fix issue where request body has already been read #3839
fix(remix): Fix issue where request body has already been read #3839
Conversation
🦋 Changeset detectedLatest commit: 3aaf608 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!snapshot |
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@1.0.5-snapshot.vb3a15ea --save-exact
npm i @clerk/backend@1.5.0-snapshot.vb3a15ea --save-exact
npm i @clerk/chrome-extension@1.1.8-snapshot.vb3a15ea --save-exact
npm i @clerk/clerk-js@5.10.3-snapshot.vb3a15ea --save-exact
npm i @clerk/elements@0.10.8-snapshot.vb3a15ea --save-exact
npm i @clerk/clerk-expo@2.0.1-snapshot.vb3a15ea --save-exact
npm i @clerk/express@0.0.22-snapshot.vb3a15ea --save-exact
npm i @clerk/fastify@1.0.24-snapshot.vb3a15ea --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/localizations@2.5.3-snapshot.vb3a15ea --save-exact
npm i @clerk/nextjs@5.2.9-snapshot.vb3a15ea --save-exact
npm i @clerk/remix@4.2.8-snapshot.vb3a15ea --save-exact
npm i @clerk/clerk-sdk-node@5.0.21-snapshot.vb3a15ea --save-exact
npm i @clerk/tanstack-start@0.1.12-snapshot.vb3a15ea --save-exact
npm i @clerk/testing@1.2.4-snapshot.vb3a15ea --save-exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I initially wondered why cloning the request wasn't sufficient, but I realized that it's possible to read the request in userland before passing it to the getAuth
helper
Description
This PR fixes a bug where the body has already been read and we try to clone the whole request and this results to an error.
Fixes #3769
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change