Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to Github Actions #276

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Move CI to Github Actions #276

merged 1 commit into from
Mar 27, 2022

Conversation

speedytwenty
Copy link
Collaborator

To address #271, this incorporates a github action which should run the tests across the same [major] versions of node as was previously setup with Travis.

[Attempting this PR from a non-fork branch to attempt to induce the action]

@speedytwenty speedytwenty requested a review from DanielRuf March 24, 2022 22:12
@speedytwenty speedytwenty linked an issue Mar 24, 2022 that may be closed by this pull request
@speedytwenty
Copy link
Collaborator Author

Waiting for a review or feedback before merging because I'm not entirely confident on the use of npm instead of yarn in the actions commands. It's likely trivial, but I wasn't able to use the npm ci command—which presumably has some efficiency benefits—because it seemed to demand a package-lock.json file.

Also noting, that I'm not sure that the badge in the readme is correct. We might tweak the profile name now that I see it's used by the badge: https://github.com/cli-table/cli-table3/blob/5dd0a6cf00b314e424f55ae46e0db3fa58bfeb41/README.md

@speedytwenty
Copy link
Collaborator Author

Alright, I renamed the action to read "Build" in the badge (and squashed commits). It should come up with a status once it hits master: https://github.com/cli-table/cli-table3/blob/5dd0a6cf00b314e424f55ae46e0db3fa58bfeb41/README.md

@DanielRuf
Copy link
Contributor

yarn is also available on GHA by default, if we need this. Yes, npm clean-install requires a lock file like yarn does for reproducible builds.

@speedytwenty
Copy link
Collaborator Author

Good to know. Thanks!

I adjusted the workflow to use yarn instead of npm. I was originally seeing this issue when attempting to use yarn but it looks like it works now.

@speedytwenty speedytwenty merged commit 72f399d into master Mar 27, 2022
@speedytwenty speedytwenty deleted the gha branch March 27, 2022 16:17
@speedytwenty speedytwenty changed the title Initial workflow action for testing PRs and commits to master Move CI to Github Actions Apr 5, 2022
speedytwenty added a commit that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis build suspended?
2 participants