FIX If the help of an argument is None, don't fail
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for a regression introduced in click-contrib#134. It's possible that the argument has a `help` attribute, but the value of it is `None`. We then hit a type error where we pass `None` to `re.sub`.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
May 9, 2024
I made two PRs to sphinx-click and this uses them: click-contrib/sphinx-click#137 click-contrib/sphinx-click#138
hoodmane
added a commit
to pyodide/pyodide
that referenced
this pull request
May 9, 2024
…gs (#4750) I made two PRs to sphinx-click and this uses them: click-contrib/sphinx-click#137 click-contrib/sphinx-click#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for a regression introduced in #134. It's possible that the argument has a
helpattribute, but the value of it isNone. We then hit a type error where we passNonetore.sub.Tasks
reno)tox)(no release note needed since it's a fix for an unreleased feature)