In i2c_read() check endTransmission() and requestFrom() to ensure data returned is valid #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions/communication/wire/endtransmission/ endTransmission() returns 0 on success and other values on error. In the case of an error i2c_read() now returns false so callers do not try to interpret invalid data. 2) As documented here https://www.arduino.cc/reference/en/language/functions/communication/wire/requestfrom/ requestFrom() returns the number of bytes returned from the peripheral. In the case of fewer bytes returned than the number requested in i2c_read() return false to callers so they do not try to interpret invalid data.
|
+1 |
climateguard
approved these changes
Nov 8, 2022
|
@climateguard / @octopolyr is it worth tagging a new release # with this fix? |
|
@bakerkj |
|
Hi @octopolyr , I was curious how the tag creation was going? Thanks! |
|
@octopolyr / @climateguard I was just checking in. Would it be possible to issue a new release? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this change addresses issues like #10 and maaad/RadSens1v2/issues/3 where i2c communications issues were not detected and therefore erroneous values were returned to the caller.
As documented here Arduino Wire endTransmission() documentation
endTransmission() returns 0 on success and other values on error.
In the case of an error i2c_read() now returns false so callers do
not try to interpret invalid data.
As documented here Arduino Wire requestFrom() documentation
requestFrom() returns the number of bytes returned from the peripheral.
In the case of fewer bytes returned than the number requested in
i2c_read() return false to callers so they do not try to interpret
invalid data.