fix issues with spaces in paths #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.5.1 |
|
Wow, that is sad :( Should we open an issue? |
|
I think we should open a bug in Node core, and get it fixed there :/.
Il giorno gio 28 giu 2018 alle 10:48 Andreas Madsen <
notifications@github.com> ha scritto:
… Wow, that is sad :( Should we open an issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL4-4i49pXqNX1jqtz1rRwhG3CmXFMks5uBJhxgaJpZM4U68e5>
.
|
|
Yea, I'll do it |
wentout
added a commit
to wentout/node-clinic-doctor
that referenced
this pull request
Apr 11, 2019
clinicjs#132 But ths still relates to current state clinicjs/node-clinic#148 So there might be changes done to fix NODE_PATH back, for legacy projects.
wentout
added a commit
to wentout/node-clinic-bubbleprof
that referenced
this pull request
Apr 11, 2019
clinicjs/node-clinic-doctor#132 But ths still relates to current state clinicjs/node-clinic#148 So there might be changes done to fix NODE_PATH back, for legacy projects.
This was referenced Apr 11, 2019
goto-bus-stop
pushed a commit
to clinicjs/node-clinic-bubbleprof
that referenced
this pull request
Apr 25, 2019
* Seems this doesn't matter anymore clinicjs/node-clinic-doctor#132 But ths still relates to current state clinicjs/node-clinic#148 So there might be changes done to fix NODE_PATH back, for legacy projects. * fix CI comma * oneliner for makeInjectPath * Additional Fix after code-review. Thanks to @goto-bus-stop ! NODE_PATH works from both prospects. * Finally got rid of broken parts.
goto-bus-stop
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Seems this doesn't matter anymore #132 But ths still relates to current state clinicjs/node-clinic#148 So there might be changes done to fix NODE_PATH back, for legacy projects. * fix CI comma & occasionally replaced logger path * onliner for makeInjectPath * Additional Fix after code-review. Thanks to @goto-bus-stop ! NODE_PATH works from both prospects. * Finally got rid of broken parts. * investigation checks issues * investigation checks issues 2 * reverting changes for the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't seem to be a way to get NODE_OPTIONS to accept
-rrequirements with spaces in them (prob a node core bug / missing feature), so to support paths with spaces we instead use good ol' NODE_PATH to point to a folder where we have your injection requires and the then load them as node_modules.