Allows tools to also use the end of a range besides just the start #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way tools can use them to easily mark the range of the text that Kibit can replace.
|
Hi! Can I interest someone in merging this? @danielcompton or @carrete maybe? Thanks!! :) |
|
Sorry @svdo, I don't have commit permissions. |
|
Sorry for the delay! This is merged now. I'll try and get a release out soon. |
|
No worries, thank you! |
|
Released in 0.1.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing an editor plugin that will allow replacing of Kibit suggestions as you type, one by one. In order to do that, I need to tell the editor what range (start line/col to end line/col) can be replaced. Kibit internally has that information, but not in a way that I can access it from the API (unless I missed something of course).
This pull request exposes the
:end-lineand:end-columnmeta so that I can use it in my editor plugin.(Note that I'm suing
identityas a reporter so that I get the data structure for further processing in my plugin.)I would be super-greatful if this can be merged and deployed, so that I don't have to publish my own fork of Kibit, which I'd rather avoid. Many thanks!