test: add test to preserve API compatibility

rusqlite_migration/src/tests/asynch.rs

@@ -118,3 +118,17 @@ async fn test_from_iter() {
     let migrations = AsyncMigrations::from_iter(vec![m_valid0(), m_valid10()]);
     assert_eq!(Ok(()), migrations.validate().await);
 }
+
+#[tokio::test]
+async fn test_tokio_rusqlite_conversion() {
+    use tokio_rusqlite::Error as TError;
+
+    insta::assert_debug_snapshot!(
+        "convert_connection_closed_error",
+        crate::Error::from(TError::ConnectionClosed)
+    );
+    insta::assert_debug_snapshot!(
+        "convert_rusqlite_error",
+        crate::Error::from(TError::Rusqlite(rusqlite::Error::InvalidQuery))
+    );
+}

rusqlite_migration/src/tests/helpers.rs

@@ -80,3 +80,57 @@ pub fn m_invalid_fk() -> M<'static> {
     )
     .foreign_key_check()
 }
+
+pub fn all_errors() -> Vec<(&'static str, crate::Error)> {
+    use crate::Error::*;
+    use crate::ForeignKeyCheckError;
+    use crate::MigrationDefinitionError;
+    use crate::SchemaVersion;
+    use crate::SchemaVersionError;
+
+    vec![
+        (
+            "rusqlite_error",
+            RusqliteError {
+                query: "SELECT * FROM table42;".to_owned(),
+                err: rusqlite::Error::InvalidQuery,
+            },
+        ),
+        (
+            "specified_schema_version",
+            SpecifiedSchemaVersion(SchemaVersionError::TargetVersionOutOfRange {
+                specified: SchemaVersion::NoneSet,
+                highest: SchemaVersion::NoneSet,
+            }),
+        ),
+        (
+            "migration_definition",
+            MigrationDefinition(MigrationDefinitionError::NoMigrationsDefined),
+        ),
+        (
+            "foreign_key_check",
+            ForeignKeyCheck(vec![
+                ForeignKeyCheckError {
+                    table: "t1".to_owned(),
+                    rowid: 1,
+                    parent: "t2".to_owned(),
+                    fkid: 2,
+                },
+                ForeignKeyCheckError {
+                    table: "t3".to_owned(),
+                    rowid: 2,
+                    parent: "t4".to_owned(),
+                    fkid: 3,
+                },
+            ]),
+        ),
+        ("hook", Hook("in hook".to_owned())),
+        ("file_load", FileLoad("file causing problem".to_owned())),
+        (
+            "unrecognized",
+            Unrecognized(Box::new(Hook("unknown".to_owned()))),
+        ),
+        #[cfg(feature = "async-tokio-rusqlite")]
+        ("connection_closed", ConnectionClosed),
+    ]
+}

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_connection_closed_error.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/asynch.rs
+expression: "crate::Error::from(TError::ConnectionClosed)"
+---
+ConnectionClosed

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_rusqlite_error.snap

@@ -0,0 +1,8 @@
+---
+source: rusqlite_migration/src/tests/asynch.rs
+expression: "crate::Error::from(TError::Rusqlite(rusqlite::Error::InvalidQuery))"
+---
+RusqliteError {
+    query: "",
+    err: InvalidQuery,
+}

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__connection_closed.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: ConnectionClosed

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__file_load.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: FileLoad("file causing problem")

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__foreign_key_check.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: ForeignKeyCheck([ForeignKeyCheckError { table: "t1", rowid: 1, parent: "t2", fkid: 2 }, ForeignKeyCheckError { table: "t3", rowid: 2, parent: "t4", fkid: 3 }])

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__hook.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: Hook("in hook")

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-4.snap → rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__migration_definition.snap

@@ -1,5 +1,5 @@
 ---
 source: rusqlite_migration/src/tests/synch.rs
-expression: "Error::MigrationDefinition(MigrationDefinitionError::NoMigrationsDefined)"
+expression: e
 ---
 rusqlite_migrate error: MigrationDefinition(NoMigrationsDefined)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__rusqlite_error.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: RusqliteError { query: "SELECT * FROM table42;", err: InvalidQuery }

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__specified_schema_version.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: SpecifiedSchemaVersion(TargetVersionOutOfRange { specified: NoneSet, highest: NoneSet })

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__unrecognized.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: Unrecognized(Hook("unknown"))

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_0.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: RusqliteError { query: "SELECT * FROM table42;", err: InvalidQuery }

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_1.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: SpecifiedSchemaVersion(TargetVersionOutOfRange { specified: NoneSet, highest: NoneSet })

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_2.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: MigrationDefinition(NoMigrationsDefined)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_3.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: ForeignKeyCheck([ForeignKeyCheckError { table: "t1", rowid: 1, parent: "t2", fkid: 2 }, ForeignKeyCheckError { table: "t3", rowid: 2, parent: "t4", fkid: 3 }])

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_4.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: Hook("in hook")

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_5.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: FileLoad("file causing problem")

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_6.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: Unrecognized(Hook("unknown"))

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_7.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+rusqlite_migrate error: ConnectionClosed

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_0.snap

@@ -0,0 +1,7 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    InvalidQuery,
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_1.snap

@@ -0,0 +1,10 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    TargetVersionOutOfRange {
+        specified: NoneSet,
+        highest: NoneSet,
+    },
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_2.snap

@@ -0,0 +1,7 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    NoMigrationsDefined,
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_3.snap

@@ -0,0 +1,12 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    ForeignKeyCheckError {
+        table: "t1",
+        rowid: 1,
+        parent: "t2",
+        fkid: 2,
+    },
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_4.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_5.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_6.snap

@@ -0,0 +1,9 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    Hook(
+        "unknown",
+    ),
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_7.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_connection_closed.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_file_load.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_foreign_key_check.snap

@@ -0,0 +1,12 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    ForeignKeyCheckError {
+        table: "t1",
+        rowid: 1,
+        parent: "t2",
+        fkid: 2,
+    },
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_hook.snap

@@ -0,0 +1,5 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+None

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_migration_definition.snap

@@ -0,0 +1,7 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    NoMigrationsDefined,
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_rusqlite_error.snap

@@ -0,0 +1,7 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    InvalidQuery,
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_specified_schema_version.snap

@@ -0,0 +1,10 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    TargetVersionOutOfRange {
+        specified: NoneSet,
+        highest: NoneSet,
+    },
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_unrecognized.snap

@@ -0,0 +1,9 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e.source()
+---
+Some(
+    Hook(
+        "unknown",
+    ),
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__read_only_db_all_valid.snap

@@ -0,0 +1,18 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+Err(
+    RusqliteError {
+        query: "CREATE TABLE m1(a, b); CREATE TABLE m2(a, b, c);",
+        err: SqliteFailure(
+            Error {
+                code: ReadOnly,
+                extended_code: 8,
+            },
+            Some(
+                "attempt to write a readonly database",
+            ),
+        ),
+    },
+)

rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__user_version_error.snap

@@ -0,0 +1,18 @@
+---
+source: rusqlite_migration/src/tests/synch.rs
+expression: e
+---
+Err(
+    RusqliteError {
+        query: "PRAGMA user_version = 1; -- Approximate query",
+        err: SqliteFailure(
+            Error {
+                code: ReadOnly,
+                extended_code: 8,
+            },
+            Some(
+                "attempt to write a readonly database",
+            ),
+        ),
+    },
+)