Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return test documentation messages as strings #550

Merged
merged 3 commits into from
Oct 14, 2018

Conversation

mallt
Copy link
Contributor

@mallt mallt commented Oct 12, 2018

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

This PR fixes cider issue 2449 by making sure test documentation messages are always returned as strings.

@bbatsov
Copy link
Member

bbatsov commented Oct 12, 2018

Please, update the changelog as well.

(assoc-in [:ns-query :has-tests?] true)
(assoc :test? true)
(util.coerce/var-query)))
(walk/postwalk (fn [x] (if (and (map? x)
Copy link
Member

@bbatsov bbatsov Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the ->> reads very well here (because both functions have non-trivial bodies and you're also nesting threadings), so you might want to extract a couple of helper functions or something like this.

@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #550 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #550      +/-   ##
=========================================
+ Coverage   73.02%   73.1%   +0.07%     
=========================================
  Files          36      36              
  Lines        2369    2376       +7     
  Branches      137     137              
=========================================
+ Hits         1730    1737       +7     
  Misses        502     502              
  Partials      137     137
Impacted Files Coverage Δ
src/cider/nrepl/middleware/test.clj 59.39% <100%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c0b92...191852f. Read the comment docs.

@bbatsov bbatsov merged commit c5f97a2 into clojure-emacs:master Oct 14, 2018
@bbatsov
Copy link
Member

bbatsov commented Oct 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cider test report does not show stack trace for test.chuck
2 participants